Unify null comparisons #11481
Merged
Unify null comparisons #11481
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wouterj
commented
Jul 26, 2014
| Q | A |
|---|---|
| Fixed tickets | - |
| License | MIT |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @wouterj. |
fabpot
added a commit
that referenced
this pull request
Jul 27, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Unify null comparisons | Q | A | ------------- | --- | Fixed tickets | - | License | MIT Commits ------- be04c50 Unify null comparisons
| @@ -68,20 +68,20 @@ | |||
| menu = document.getElementById('navigation'), savedState = Sfjs.getPreference('menu/displayState'), | |||
| displayState, elem, className; | |||
|
|
|||
| if (savedState == null) { | |||
| if (null === savedState) { | |||
There was a problem hiding this comment.
You won't catch undefined with this check. null == savedState <=> null === savedState || undefined === savedState.
Not sure if this was intended here.
There was a problem hiding this comment.
Applies further down, too.
There was a problem hiding this comment.
Looks like it was replaced automatically (this part is JavaScript). @wouterj Can you have a look at this?
There was a problem hiding this comment.
I've checked all JS conditions comparing with null in this PR and they all remain to work. All functions used in these conditions return null or a value.
There was a problem hiding this comment.
Thanks @apfelbox for noting this. You've a sharp eye :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.