Skip to content

[WIP] [Security] Session concurrency control #12009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Mark as private several methods and properties
  • Loading branch information
ajgarlag committed Nov 10, 2014
commit 9c3aebb59726a7c0e882d1d7be8cf81ed9812adc
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public function __construct($table)
/**
* Adds the session_information table to the schema
*/
protected function addSessionInformationTable($table)
private function addSessionInformationTable($table)
{
$table = $this->createTable($table);
$table->addColumn('session_id', 'string');
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
*/
class SessionRegistryStorage implements SessionRegistryStorageInterface
{
protected $connection;
protected $table;
private $connection;
private $table;

public function __construct(Connection $connection, $table)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing PHPdoc in this constructor

{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@
*/
class SessionInformation
{
protected $sessionId;
protected $username;
protected $expired;
protected $lastRequest;
private $sessionId;
private $username;
private $expired;
private $lastRequest;

public function __construct($sessionId, $username, \DateTime $lastRequest, \DateTime $expired = null)
{
Expand Down Expand Up @@ -94,17 +94,17 @@ public function refreshLastRequest()
$this->lastRequest = new \DateTime();
}

protected function getExpired()
private function getExpired()
{
return $this->expired;
}

protected function setExpired(\DateTime $expired)
private function setExpired(\DateTime $expired)
{
$this->expired = $expired;
}

protected function setLastRequest(\DateTime $lastRequest)
private function setLastRequest(\DateTime $lastRequest)
{
$this->lastRequest = $lastRequest;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
*/
class SessionRegistry
{
protected $sessionRegistryStorage;
private $sessionRegistryStorage;

public function __construct(SessionRegistryStorageInterface $sessionRegistryStorage)
{
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy