[HttpFoundation] fix checkip6 #12572
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure if this fix is the right way to deal with your issue. X.X.X.X:X is no valid IP address (neither IPv4 nor IPv6). |
|
Yes, i'm ok with you but i think that it's a more effective ipv6 check. |
|
👍 The root cause is fixed in #13114 |
|
👍 |
|
Thank you @Neime. |
fabpot
added a commit
that referenced
this pull request
Dec 29, 2014
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #12572). Discussion ---------- [HttpFoundation] fix checkip6 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I have this error ContextErrorException: Warning: inet_pton(): Unrecognized address X.X.X.X:X in IpUtils.php line 110 X.X.X.X:X is detected as a ipv6 because HTTP_X_FORWARDED_FOR have a port. Commits ------- 1da0ba4 [Debug] fix checkip6
fabpot
added a commit
that referenced
this pull request
Dec 29, 2014
…-For HTTP head... (fabpot) This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP head... | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a On symfony.com, we have errors related to IP addresses in the `X-Forwarded-For` HTTP header that have a port. If that happens (I have no ideas what is doing that), the page crashes with an error like `inet_pton(): Unrecognized address 187.65.229.211:63479` (which comes from IpUtils::checkIpv6()). This fixes the root cause by removing the port. #12572 is solving the consequence and I propose to also merge it. Commits ------- 60ad382 [HttpFoundation] fixed error when an IP in the X-Forwarded-For HTTP header contains a port
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have this error ContextErrorException: Warning: inet_pton(): Unrecognized address X.X.X.X:X
in IpUtils.php line 110
X.X.X.X:X is detected as a ipv6 because HTTP_X_FORWARDED_FOR have a port.