Skip to content

[FrameworkBundle] Check if templating is enabled. #13711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2015
Merged

[FrameworkBundle] Check if templating is enabled. #13711

merged 1 commit into from
Feb 17, 2015

Conversation

jakzal
Copy link
Contributor

@jakzal jakzal commented Feb 17, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #13710
License MIT
Doc PR -

templating can be disabled.

@fabpot
Copy link
Member

fabpot commented Feb 17, 2015

Thank you @jakzal.

@fabpot fabpot merged commit c75b276 into symfony:2.7 Feb 17, 2015
fabpot added a commit that referenced this pull request Feb 17, 2015
@fabpot
bug #13711 [FrameworkBundle] Check if templating is enabled. (jakzal)
a630d87 
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Check if templating is enabled.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13710
| License       | MIT
| Doc PR        | -

templating can be disabled.

Commits
-------

c75b276 [FrameworkBundle] Check if templating is enabled.
@jakzal jakzal deleted the assets-fix branch February 17, 2015 12:03
@wouterj
Copy link
Member

wouterj commented Feb 17, 2015

Btw, why is ->validation() used and not ->beforeNormalization()?

@jakzal
Copy link
Contributor Author

jakzal commented Feb 17, 2015

@wouterj reason for using validate() is that the configs need to be merged before we decide if assets should be enabled. Otherwise there's a risk that assets would be enabled even if templating was configured in one of the config files (but not the others).

From the docs:

When the config files are processed they are first normalized, then merged and finally the tree is used to validate the resulting array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakzal @fabpot @wouterj
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy