Skip to content

[FrameworkBundle][DX] Add option to specify additional translation loading paths #14561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[FrameworkBundle][DX] Add option to specify additional translation loading paths #14561

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e66caae
[FrameworkBundle][DX] Add option to specify additional translation lo…
Seldaek May 5, 2015
ee98c2b
Fix configuration change
Seldaek May 6, 2015
3ea7ab8
Remove redundant default
Seldaek May 6, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix configuration change
  • Loading branch information
@Seldaek
Seldaek committed May 6, 2015
commit ee98c2bbf8872c10b610cf8afb3d50442de42a0c
4 changes: 1 addition & 3 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,16 +575,14 @@ private function addTranslatorSection(ArrayNodeDefinition $rootNode)
->info('translator configuration')
->canBeEnabled()
->fixXmlConfig('fallback')
->fixXmlConfig('path')
->children()
->arrayNode('fallbacks')
->beforeNormalization()->ifString()->then(function ($v) { return array($v); })->end()
->prototype('scalar')->end()
->defaultValue(array('en'))
->end()
->booleanNode('logging')->defaultValue($this->debug)->end()
->end()
->fixXmlConfig('path')
->children()
->arrayNode('paths')
->prototype('scalar')->end()
->defaultValue(array())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the defaultValue is useless here. It is already the case for a prototyped node

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, fixing

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy