InvalidResourceException file name #14762
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added filen ame to the InvalidResourceException,
| @@ -148,7 +148,7 @@ private function parseFile($file) | |||
| $source = str_replace('http://www.w3.org/2001/xml.xsd', $location, $source); | |||
|
|
|||
| if (!@$dom->schemaValidateSource($source)) { | |||
| throw new InvalidResourceException(implode("\n", $this->getXmlErrors($internalErrors))); | |||
| throw new InvalidResourceException("File:$file\n".implode("\n", $this->getXmlErrors($internalErrors))); | |||
There was a problem hiding this comment.
Let's be more verbose and say something like The "file.xlf" is not a valid resource.
Also, our coding standard favours single quotes, and sprintf should be used to create an exception message:
throw new InvalidResourceException(sprintf('The "%s" is not a valid resource: ', $file, implode("\n", $this->getXmlErrors($internalErrors))));Refactored InvalidResourceException message.
| @@ -148,7 +148,7 @@ private function parseFile($file) | |||
| $source = str_replace('http://www.w3.org/2001/xml.xsd', $location, $source); | |||
|
|
|||
| if (!@$dom->schemaValidateSource($source)) { | |||
| throw new InvalidResourceException(implode("\n", $this->getXmlErrors($internalErrors))); | |||
| throw new InvalidResourceException(sprintf('The "%s" is not a valid resource: ', $file, implode("\n", $this->getXmlErrors($internalErrors)))); | |||
There was a problem hiding this comment.
The "my_file.xml" is not a valid resource, This sounds a bit weird. What if you format it like this?
'Invalid resource provided: "%s"; Errors: %s', note that you forgot the second %s in your commit.
|
👍 should be merged in 2.3 |
|
Thank you @DancZer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added filen ame to the InvalidResourceException,