Revert "feature #13756 [3.0][Console] Added type hint (francisbesset)" #15657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 30, 2015
|
The OutputInterface typehint should stay as this has nothing to do with php 7 compatibility and we already agreed to add it. |
|
So, thinking twice about this one, I'm closing: throwables should be handled differently, and in fact we already do with the debug component (they are converted to exception then re-injected into this code path). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit ad1888b, reversing
changes made to fffcc24.
The rationale behind this change is that type hinting against Exception is not compatible with PHP7.
The second level rational is that this creates a BC break that can easilly be prevented.
This PR will be seconded by an other one on 2.3 that will allow catching then rendering throwables, and add an
instanceoftype check for $output.Merging this one first will prevent merge conflicts.