Skip to content

Using a service as a router resource #15742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 18 commits into from
Closed

Using a service as a router resource #15742

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
b6b2cc8
Adding a new route loader that is able to load routes from a service
weaverryan Sep 9, 2015
423f6b0
Registering the route loader as a service
weaverryan Sep 9, 2015
ca1229f
fabbot!
weaverryan Sep 9, 2015
cf7af64
Moving the ServiceRouteLoader stuff into the Routing component as an …
weaverryan Sep 10, 2015
5d34c96
Some tweaks thanks to @jakzal
weaverryan Sep 10, 2015
c129cdd
Hinting against the interface
weaverryan Sep 10, 2015
8440be2
Adding the entire class hierarchy as a resource
weaverryan Sep 13, 2015
2bb0adc
Fixing typo
weaverryan Sep 14, 2015
ee90412
Fixing comment typo
weaverryan Sep 22, 2015
de4143a
Fixing test - bad mock
weaverryan Sep 24, 2015
eb47a69
Fixing bad mock of "abstract" class
weaverryan Sep 26, 2015
3cb24eb
Changing this to be an abstract ObjectRouteLoader
weaverryan Sep 30, 2015
e431fc7
Adding a ServiceRouterLoader that works with the DependencyInjection …
weaverryan Sep 30, 2015
43e9ad2
Renaming abstract method and going back to the key "service" as the type
weaverryan Sep 30, 2015
7ed22ce
fabbot
weaverryan Sep 30, 2015
6b0a5c6
Updating ObjectRouteLoader to use a service_id:methodName format
weaverryan Oct 1, 2015
a4af474
updating CHANGELOG
weaverryan Oct 1, 2015
a2cb797
Fixing missing gettype
weaverryan Oct 1, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fabbot
  • Loading branch information
@weaverryan
weaverryan committed Sep 30, 2015
commit 7ed22ce5fe04ab2fd3918e28b08819b9803e5a6e
3 changes: 0 additions & 3 deletions src/Symfony/Component/Routing/Loader/DependencyInjection/ServiceRouterLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,8 @@
namespace Symfony\Component\Routing\Loader\DependencyInjection;

use Symfony\Component\Config\Loader\Loader;
use Symfony\Component\Config\Resource\FileResource;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\Routing\Loader\ObjectRouteLoader;
use Symfony\Component\Routing\Loader\RouteLoaderInterface;
use Symfony\Component\Routing\RouteCollection;

/**
* A route loader that executes a service to load the routes.
Expand Down
1 change: 1 addition & 0 deletions src/Symfony/Component/Routing/Loader/ObjectRouteLoader.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ public function supports($resource, $type = null)
* the $id may be a service id.
*
* @param string $id
*
* @return RouteLoaderInterface
*/
abstract protected function getRouteLoaderService($id);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove the RouteLoaderInterface and instead have this method return a callable.

The difference would then be that we'd probably need to include the method name in the "resource" when using this:

admin_routes:
    resource: 'admin_route_loader::loadRoutes'
    type: service

That would solve the need for the RouteLoaderInterface on the "Micro" kernel.

Expand Down
5 changes: 2 additions & 3 deletions src/Symfony/Component/Routing/Tests/Loader/ObjectRouteLoaderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
namespace Symfony\Component\Routing\Tests\Loader;

use Symfony\Component\Routing\Loader\ObjectRouteLoader;
use Symfony\Component\Routing\Loader\RouteLoaderInterface;
use Symfony\Component\Routing\Route;
use Symfony\Component\Routing\RouteCollection;

Expand All @@ -24,7 +23,7 @@ public function testLoadCallsServiceAndReturnsCollection()
$serviceRouteLoader = new ObjectRouteLoaderForTest();

$serviceRouteLoader->loaderMap = array(
'my_route_provider_service' => $routeLoader
'my_route_provider_service' => $routeLoader,
);

// create a basic collection that will be returned
Expand Down Expand Up @@ -55,7 +54,7 @@ public function testExceptionOnInterfaceNotImplemented()

$serviceRouteLoader = new ObjectRouteLoaderForTest();
$serviceRouteLoader->loaderMap = array(
'any_service_name' => $routeLoader
'any_service_name' => $routeLoader,
);

$serviceRouteLoader->load('any_service_name', 'service');
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy