Skip to content

[Filesystem] Changed dumpFile to allow dumping to streams #16156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2015
Merged

[Filesystem] Changed dumpFile to allow dumping to streams #16156

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c6a7747
[Filesystem] added tempnam() stream wrapper aware version of PHP's na…
markchalloner May 7, 2015
247266c
Update coding standard for MockStream
pierredup Oct 6, 2015
61a3afd
Removed unused logic in MockStream
pierredup Oct 8, 2015
a17aa5e
Fixed failing test for HHVM
pierredup Oct 12, 2015
5ca7dee
Fix mode
pierredup Oct 19, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed failing test for HHVM
  • Loading branch information
@pierredup
pierredup committed Nov 9, 2015
commit a17aa5e091585ef0599e941a1cbc0d786833d85b
2 changes: 1 addition & 1 deletion src/Symfony/Component/Filesystem/Filesystem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,6 @@ private function getSchemeAndHierarchy($filename)
{
$components = explode('://', $filename, 2);

return 2 === count($components) ? array($components[0], $components[1]) : array(null, $components[0]);
return 2 === count($components) ? array($components[0], $components[1]) : array(null, $components[0]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldnt this be simlified to

return 2 === count($components) ? $components : array(null, $components[0]);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems so

}
}
6 changes: 5 additions & 1 deletion src/Symfony/Component/Filesystem/Tests/FilesystemTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,7 +1047,7 @@ public function testTempnamOnUnwritableFallsBackToSysTmp()
$this->assertFileExists($filename);

// Tear down
unlink($filename);
@unlink($filename);
}

public function testDumpFile()
Expand Down Expand Up @@ -1106,6 +1106,10 @@ public function testDumpFileOverwritesAnExistingFile()

public function testDumpFileWithFileScheme()
{
if (defined('HHVM_VERSION')) {
$this->markTestSkipped('HHVM does not handle the file:// scheme correctly');
}

$scheme = 'file://';
$filename = $scheme.$this->workspace.DIRECTORY_SEPARATOR.'foo'.DIRECTORY_SEPARATOR.'baz.txt';

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy