[Form] Enhance some FormRegistry deprecation messages #16568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Nov 17, 2015
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
1032b51 to
c8ec6bf
Compare
| @@ -120,7 +120,7 @@ private function resolveAndAddType(FormTypeInterface $type) | |||
| $hasCustomName = $name !== $fqcn; | |||
|
|
|||
| if ($parentType instanceof FormTypeInterface) { | |||
| @trigger_error('Returning a FormTypeInterface from FormTypeInterface::getParent() is deprecated since version 2.8 and will be removed in 3.0.', E_USER_DEPRECATED); | |||
| @trigger_error(sprintf('Returning a FormTypeInterface from %s::getParent() is deprecated since version 2.8 and will be removed in 3.0.', $fqcn), E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
You could add Return the fully-qualified type class name instead. there as well.
c8ec6bf to
02d2148
Compare
|
👍 |
1 similar comment
|
👍 |
|
Thank you @nicolas-grekas. |
Tobion
added a commit
that referenced
this pull request
Nov 17, 2015
…icolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [Form] Enhance some FormRegistry deprecation messages | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 02d2148 [Form] Enhance some FormRegistry deprecation messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.