Fixes the stack traces of the deprecation logs #16658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Nice Status: Reviewed |
|
👍 |
|
Thank you Javier. |
Tobion
added a commit
that referenced
this pull request
Nov 25, 2015
…uiluz) This PR was merged into the 2.8 branch. Discussion ---------- Fixes the stack traces of the deprecation logs | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #16640 | License | MIT | Doc PR | The stack trace information was displayed in a very confusing way. Now it's easier to understand what is called from which file and line. ### Before  ### After  Commits ------- 09f4895 Fixes the stack traces of the deprecation logs
|
@javiereguiluz would it make sense to wrap all inline code fragments with |
|
@apfelbox it would probably be "better" ... but at the same time very boring to do. Since the profiler is something internal and for developers only, we can skip some "correctness". |
|
@javiereguiluz I didn't mean from a semantic point of view but by using a monospaced font for inline |
|
(I mean for the stack trace, I know that we can't do that for the deprecation message itself…) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stack trace information was displayed in a very confusing way. Now it's easier to understand what is called from which file and line.
Before
After