Skip to content

[Form] [ChoiceType] Prefer placeholder to empty_value #16886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[Form] [ChoiceType] Prefer placeholder to empty_value #16886

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3410779
[Form] Use strict comparison assertions in tests
boite Dec 7, 2015
9ed36d1
[Form] Prefer placeholder option to empty_value
boite Dec 7, 2015
3c31a91
Fix typos in test dataset names.
boite Feb 16, 2016
a5d4e3f
Collapse multi-line test method sig.
boite Feb 29, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Collapse multi-line test method sig.
  • Loading branch information
@boite
boite committed Feb 29, 2016
commit a5d4e3fb639b6bb14ff9edddf855f90bea7bb688
10 changes: 2 additions & 8 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/ChoiceTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1730,14 +1730,8 @@ public function getOptionsWithPlaceholder()
* @dataProvider getOptionsWithPlaceholderAndEmptyValue
* @group legacy
*/
public function testPlaceholderOptionWithEmptyValueOption(
$multiple,
$expanded,
$required,
$placeholder,
$emptyValue,
$viewValue
) {
public function testPlaceholderOptionWithEmptyValueOption($multiple, $expanded, $required, $placeholder, $emptyValue, $viewValue)
{
$form = $this->factory->create('choice', null, array(
'multiple' => $multiple,
'expanded' => $expanded,
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy