Skip to content

[DomCrawler] Revert previous restriction, allow selection of every DOMNode object #17021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

[DomCrawler] Revert previous restriction, allow selection of every DOMNode object #17021

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e919b71
[DomCrawler] Revert previous restriction, allow selection of every DO…
EdgarPE Dec 15, 2015
1d0d5ea
[DomCrawler] Re-add DOMDocument type hints in Form, Link and fields
EdgarPE Dec 15, 2015
408d0bd
Coding standard fixes.
EdgarPE Dec 15, 2015
1ebb09c
Remove extra blank line.
EdgarPE Dec 15, 2015
e403289
[DomCrawler] Spelling and clarification.
EdgarPE Dec 16, 2015
5d99e77
CS fix
EdgarPE Dec 17, 2015
f5bdb38
Grammar fix.
EdgarPE Dec 17, 2015
a8f1c90
Remove expectedExceptionMessageRegExp from tests.
EdgarPE Dec 18, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Coding standard fixes.
  • Loading branch information
@EdgarPE
EdgarPE committed Dec 22, 2015
commit 408d0bdb030f1a45fcc2e59d70955e53eccf8eb2
6 changes: 3 additions & 3 deletions src/Symfony/Component/DomCrawler/Crawler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,7 +702,7 @@ public function link($method = 'get')

$node = $this->getNode(0);

if(!$node instanceof \DOMElement) {
if (!$node instanceof \DOMElement) {
throw new \InvalidArgumentException(sprintf("The current node list should contain only DOMElement instances, '%s' found.", get_class($node)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, we should use single quotes to enclose the message, and double quotes inside the message:

throw new \InvalidArgumentException(sprintf('The current node list should contain only DOMElement instances, "%s" found.', get_class($node)));

}

Expand All @@ -720,7 +720,7 @@ public function links()
{
$links = array();
foreach ($this->nodes as $node) {
if(!$node instanceof \DOMElement) {
if (!$node instanceof \DOMElement) {
throw new \InvalidArgumentException(sprintf("The current node list should contain only DOMElement instances, '%s' found.", get_class($node)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enclose the message in single quotes please.

}

Expand Down Expand Up @@ -748,7 +748,7 @@ public function form(array $values = null, $method = null)

$node = $this->getNode(0);

if(!$node instanceof \DOMElement) {
if (!$node instanceof \DOMElement) {
throw new \InvalidArgumentException(sprintf("The current node list should contain only DOMElement instances, '%s' found.", get_class($node)));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enclose the message in single quotes please.

}

Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy