Skip to content

[2.8] fix mocks #18321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

[2.8] fix mocks #18321

wants to merge 3 commits into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 26, 2016

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

xabbuh added 2 commits March 26, 2016 08:59
@xabbuh
update cache ID
c3ba6bf
@xabbuh
fix mocks
fafc370 
* check for existance of `setMetadataFactory()` method (this is needed
  for tests run with deps=high as the method was removed in Symfony
  3.0)
* fix mock testing the `EngineInterface` as the `stream()` method cannot
  be mocked when it is does not exist in the mocked interface
@xabbuh xabbuh force-pushed the fix-mocks-2.8 branch 2 times, most recently from 67dde28 to df23ec9 Compare March 26, 2016 08:38
@xabbuh xabbuh changed the title [WIP][2.8] fix mocks [2.8] fix mocks Mar 26, 2016
@xabbuh
Copy link
Member Author

xabbuh commented Mar 26, 2016

Tests are passing now. This one needs a rebase once the 2.7 branch is merged up.

xabbuh
xabbuh reviewed Mar 26, 2016
View reviewed changes
phpunit
@@ -11,7 +11,7 @@
*/

// Please update when phpunit needs to be reinstalled with fresh deps:
// Cache-Id-Version: 2016-03-23 14:50 UTC
// Cache-Id-Version: 2016-03-25 09:45 UTC
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the same value as in the two fixed branches.

@xabbuh
fix mocks
d330881 
* skip tests with `deps=high` when legacy classes/methods are not
  present in Symfony 3.0
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

nicolas-grekas added a commit that referenced this pull request Mar 27, 2016
@nicolas-grekas
minor #18321 [2.8] fix mocks (xabbuh)
6376ea2 
This PR was squashed before being merged into the 2.8 branch (closes #18321).

Discussion
----------

[2.8] fix mocks

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

7dff706 [2.8] fix mocks
@xabbuh xabbuh deleted the fix-mocks-2.8 branch March 27, 2016 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @nicolas-grekas @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy