added type info to profiles

symfony · yjv · Sep 28, 2016 · Sep 28, 2016 · Nov 6, 2016 · Nov 6, 2016
commit b616f96c7e551128fb2ce109dacbeca1d81fde0d
diff --git a/src/Symfony/Component/Profiler/Context/ConsoleCommandContext.php b/src/Symfony/Component/Profiler/Context/ConsoleCommandContext.php
@@ -33,27 +33,26 @@ public function __construct(Command $command, $exitCode, $exception = null)
         $this->command = $command;
     }
 
-    /**
-     * @return \Exception|\Throwable|null
-     */
     public function getException()
     {
         return $this->exception;
     }
 
-    /**
-     * @return null|string
-     */
     public function getName()
     {
-        return sprintf('command=>%s', $this->command->getName());
+        return sprintf('command => %s', $this->command->getName());
     }
 
-    /**
-     * @return null|string
-     */
     public function getStatusCode()
     {
         return $this->exitCode;
     }
+
+    /**
+     * @return string
+     */
+    public function getType()
+    {
+        return Types::COMMAND;
+    }
 }
diff --git a/src/Symfony/Component/Profiler/Context/ContextInterface.php b/src/Symfony/Component/Profiler/Context/ContextInterface.php
@@ -16,12 +16,17 @@ interface ContextInterface
     public function getException();
 
     /**
-     * @return null|string
+     * @return string
      */
     public function getName();
 
     /**
-     * @return null|string
+     * @return string
+     */
+    public function getType();
+
+    /**
+     * @return null|int
      */
     public function getStatusCode();
 }
diff --git a/src/Symfony/Component/Profiler/Context/RequestContext.php b/src/Symfony/Component/Profiler/Context/RequestContext.php
@@ -58,4 +58,12 @@ public function getResponse()
     {
         return $this->response;
     }
+
+    /**
+     * @return string
+     */
+    public function getType()
+    {
+        return Types::REQUEST;
+    }
 }
diff --git a/src/Symfony/Component/Profiler/Context/Types.php b/src/Symfony/Component/Profiler/Context/Types.php
@@ -0,0 +1,16 @@
+<?php
+/**
+ * Created by PhpStorm.
+ * User: yosefderay
+ * Date: 11/5/16
+ * Time: 9:21 PM
+ */
+
+namespace Symfony\Component\Profiler\Context;
+
+
+final class Types
+{
+    const REQUEST = 'request';
+    const COMMAND = 'command';
+}
diff --git a/src/Symfony/Component/Profiler/Profile.php b/src/Symfony/Component/Profiler/Profile.php
@@ -32,6 +32,7 @@ class Profile
     private $name;
     private $time;
     private $statusCode;
+    private $type;
 
     /**
      * @var Profile
@@ -198,6 +199,22 @@ public function getChildren()
         return $this->children;
     }
 
+    /**
+     * @return mixed
+     */
+    public function getType()
+    {
+        return $this->type;
+    }
+
+    /**
+     * @param mixed $type
+     */
+    public function setType($type)
+    {
+        $this->type = $type;
+    }
+
     /**
      * Sets children profiler.
      *

diff --git a/src/Symfony/Component/Profiler/Profiler.php b/src/Symfony/Component/Profiler/Profiler.php
@@ -146,22 +146,23 @@ public function find($ip, $url, $limit, $method, $statusCode, $start, $end)
     /**
      * Collects data for the given response.
      *
-     * @param ContextInterface $data
+     * @param ContextInterface $context
      * @return null|Profile A Profile instance or null if the profiler is disabled
      */
-    public function collectData(ContextInterface $data)
+    public function collectData(ContextInterface $context)
     {
         if (false === $this->enabled) {
             return null;
         }
 
         $profile = new Profile(substr(hash('sha256', uniqid(mt_rand(), true)), 0, 6));
         $profile->setTime(time());
-        $profile->setName($data->getName());
-        $profile->setStatusCode($data->getStatusCode());
+        $profile->setName($context->getName());
+        $profile->setStatusCode($context->getStatusCode());
+        $profile->setType($context->getType());
 
         foreach ($this->collectors as $collector) {
-            if ($collector->collectData($data, $profile)) {
+            if ($collector->collectData($context, $profile)) {
                 // we need to clone for sub-requests
                 $profile->addCollector(clone $collector);
             }