symfony · Nyholm · Jan 13, 2017 · Jan 13, 2017 · Jan 16, 2017 · Jan 16, 2017
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/ValidateWorkflowsPass.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/ValidateWorkflowsPass.php
@@ -16,6 +16,7 @@
 use Symfony\Component\DependencyInjection\Exception\RuntimeException;
 use Symfony\Component\Workflow\Validator\DefinitionValidatorInterface;
 use Symfony\Component\Workflow\Validator\StateMachineValidator;
+use Symfony\Component\Workflow\Validator\UniqueTransitionNameValidator;
 use Symfony\Component\Workflow\Validator\WorkflowValidator;
 
 /**
@@ -40,6 +41,7 @@ public function process(ContainerBuilder $container)
                 }
 
                 $this->createValidator($tag)->validate($definition, $tag['name']);
+                (new UniqueTransitionNameValidator())->validate($definition, $tag['name']);
             }
         }
     }

diff --git a/src/Symfony/Component/Workflow/Tests/Validator/UniqueTransitionNameValidatorTest.php b/src/Symfony/Component/Workflow/Tests/Validator/UniqueTransitionNameValidatorTest.php
@@ -0,0 +1,51 @@
+<?php
+
+namespace Symfony\Component\Workflow\Tests\Validator;
+
+use Symfony\Component\Workflow\Definition;
+use Symfony\Component\Workflow\Tests\WorkflowBuilderTrait;
+use Symfony\Component\Workflow\Transition;
+use Symfony\Component\Workflow\Validator\UniqueTransitionNameValidator;
+
+class UniqueTransitionNameValidatorTest extends \PHPUnit_Framework_TestCase
+{
+    use WorkflowBuilderTrait;
+
+    /**
+     * @expectedException \Symfony\Component\Workflow\Exception\InvalidDefinitionException
+     * @expectedExceptionMessage All transitions for a place must have an unique name. Multiple transitions named "t1" where found for place "a" in workflow "foo".
+     */
+    public function testWorkflowWithInvalidNames()
+    {
+        $places = range('a', 'c');
+
+        $transitions = array();
+        $transitions[] = new Transition('t1', 'a', 'b');
+        $transitions[] = new Transition('t1', 'a', 'c');
+
+        $definition = new Definition($places, $transitions);
+
+        (new UniqueTransitionNameValidator())->validate($definition, 'foo');
+    }
+
+    public function testSameTransitionNameButNotSamePlace()
+    {
+        $places = range('a', 'd');
+
+        $transitions = array();
+        $transitions[] = new Transition('t1', 'a', 'b');
+        $transitions[] = new Transition('t1', 'b', 'c');
+        $transitions[] = new Transition('t1', 'd', 'c');
+
+        $definition = new Definition($places, $transitions);
+
+        (new UniqueTransitionNameValidator())->validate($definition, 'foo');
+    }
+
+    public function testValidWorkflow()
+    {
+        $definition = $this->createSimpleWorkflowDefinition();
+
+        (new UniqueTransitionNameValidator())->validate($definition, 'foo');
+    }
+}
diff --git a/src/Symfony/Component/Workflow/Validator/UniqueTransitionNameValidator.php b/src/Symfony/Component/Workflow/Validator/UniqueTransitionNameValidator.php
@@ -0,0 +1,36 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Fabien Potencier <fabien@symfony.com>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Workflow\Validator;
+
+use Symfony\Component\Workflow\Definition;
+use Symfony\Component\Workflow\Exception\InvalidDefinitionException;
+
+/**
+ * Make sure all transitions for one place has unique name.
+ *
+ * @author Tobias Nyholm <tobias.nyholm@gmail.com>
+ */
+class UniqueTransitionNameValidator implements DefinitionValidatorInterface
+{
+    public function validate(Definition $definition, $name)
+    {
+        $places = array_fill_keys($definition->getPlaces(), array());
+        foreach ($definition->getTransitions() as $transition) {
+            foreach ($transition->getFroms() as $from) {
+                if (in_array($transition->getName(), $places[$from])) {
+                    throw new InvalidDefinitionException(sprintf('All transitions for a place must have an unique name. Multiple transitions named "%s" where found for place "%s" in workflow "%s".', $transition->getName(), $from, $name));
+                }
+                $places[$from][] = $transition->getName();
+            }
+        }
+    }
+}