[FrameworkBundle] Fix third level headers for MarkdownDescriptor #21324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 Status: Reviewed |
|
Thank you @ogizanagi. |
fabpot
added a commit
that referenced
this pull request
Jan 17, 2017
…scriptor (ogizanagi) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] Fix third level headers for MarkdownDescriptor | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | N/A | License | MIT | Doc PR | N/A `~` is not valid as an underlining char when using markdown on the contrary of reStructuredText. See the rendering of [builder_1_public.md (before)](https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_public.md) vs [builder_1_public.md (after)](https://github.com/ogizanagi/symfony/blob/fix/2.7/fwb/md_third_lvl_headers/src/Symfony/Bundle/FrameworkBundle/Tests/Fixtures/Descriptor/builder_1_public.md) for instance. This PR fixes it by using a third level header. ~~**EDIT:** There is no BC break. Wrong PR template information.~~ Commits ------- ce29ab1 [FrameworkBundle] Fix third level headers for MarkdownDescriptor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~is not valid as an underlining char when using markdown on the contrary of reStructuredText.See the rendering of builder_1_public.md (before) vs builder_1_public.md (after) for instance.
This PR fixes it by using a third level header.
EDIT: There is no BC break. Wrong PR template information.