[Validator] Add min/max amount of pixels to Image constraint #23429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle] Wire inner translator | Q | A | ------------- | --- | Branch? | 3.4 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #23293 (comment) | License | MIT | Doc PR | N/A Commits ------- a32cae5 [FrameworkBundle] Wire inner translator
… Normalizer/Denormalizer
… Method for the Normalizer/Denormalizer (jordscream) This PR was merged into the 3.4 branch. Discussion ---------- [Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | ? | Deprecations? | no | Tests pass? | yes | Fixed tickets | #23314 | License | MIT | Doc PR | symfony/symfony-docs Deal it with Has Method for the Normalizer/Denormalizer Commits ------- a15829d [Component][Serializer][Normalizer] : Deal it with Has Method for the Normalizer/Denormalizer
…piaf) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][HttpKernel] Move httpkernel pass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | part of #21284 | License | MIT | Doc PR | n/a Move addcachearmer, addcacheclearer compiler pass to httpkernel Commits ------- 83727c7 [FrameworkBundle][HttpKernel] Move addcachearmer, addcacheclearer compiler pass
…er pass (lepiaf) This PR was merged into the 3.4 branch. Discussion ---------- [FrameworkBundle][Translation] Move translation compiler pass | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | part of #21284 | License | MIT | Doc PR | n/a move TranslationDumperPass, TranslationExtractorPass, TranslatorPass to Translation component. Commits ------- 74c951f [FrameworkBundle][Translation] Move translation compiler pass
…e-moe) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #22341). Discussion ---------- [BrowserKit] Emulate back/forward browser navigation | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes | New feature? | no | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | #22336 | License | MIT | Doc PR | CHANGELOG.md updated Hi all, please review this code for emulating back/forward browser navigation (skip redirects). If code is ok I will add tests and docs Commits ------- 680da44 [BrowserKit] Emulate back/forward browser navigation
|
This should be merged into 3.4, not master. So closing this pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for asserting image sizes/areas in pixels, for instance to estimate processing work load.
This PR continues #22288. I cleaned up my associated branch a while ago and found no way of restoring or re-linking.
@fabpot: "Could you rename to TOO_FEW_PIXEL_ERROR? Same for the other constant?"
This is done.
@fabpot "Can you change the base to 3.4 instead of master and rebase on current 3.4? Thanks."
This is done too.