[DI] compute autowiring error messages lazily #29108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b90172a to
d4f407d
Compare
stloyd
suggested changes
Nov 6, 2018
Tobion
approved these changes
Nov 6, 2018
stof
reviewed
Nov 6, 2018
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
614e793 to
2244d79
Compare
2244d79 to
3b3a1bd
Compare
chalasr
approved these changes
Dec 12, 2018
nicolas-grekas
added a commit
that referenced
this pull request
Dec 13, 2018
…-grekas) This PR was merged into the 4.3-dev branch. Discussion ---------- [DI] compute autowiring error messages lazily | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29019 | License | MIT | Doc PR | - As suggested in the linked issue: > the error message may ultimately be "hidden" because the definition in question is removed... and so we're doing work unnecessarily. Commits ------- 3b3a1bd [DI] compute autowiring error messages lazily
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in the linked issue: