Skip to content

[DependencyInjection] Define default priority inside service class #31943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

[DependencyInjection] Define default priority inside service class #31943

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e2138ad
Define default priority inside service class
pcabreus Jun 7, 2019
bd88e1e
Update YamlFileLoader.php
pcabreus Jun 10, 2019
2df617e
added ability to define an priority method for a tagged collection
pcabreus Jun 10, 2019
4fed2a3
Merge branch '4.4' into patch-1
pcabreus Jun 10, 2019
b6069b2
fixed fabbot.io code standard
pcabreus Jun 10, 2019
5498824
fixed spell
pcabreus Jun 11, 2019
8ab9cfd
compare using null
pcabreus Jun 11, 2019
f48eea9
better exception decription
pcabreus Jun 11, 2019
c021fc8
fixed some code standard
pcabreus Jun 11, 2019
2d8fd1f
fixed some code standard
pcabreus Jun 11, 2019
6b51ac5
fixed arguments order
pcabreus Jun 12, 2019
b9dd5eb
using the `tagged_iterator` instead deprecated `tagged`
pcabreus Jun 12, 2019
41f5e99
optional priority method unless you define it
pcabreus Jun 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed some code standard
  • Loading branch information
@pcabreus
pcabreus committed Jun 11, 2019
commit c021fc8452703627c01dfbdf50c398355b039cfe
37 changes: 6 additions & 31 deletions src/Symfony/Component/DependencyInjection/Compiler/PriorityTaggedServiceTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,43 +63,18 @@ private function findAndSortTaggedServices($tagName, ContainerBuilder $container

$priority = 0;
if ($defaultPriorityMethod && $r->hasMethod($defaultPriorityMethod)) {
if (!($rpm = $r->getMethod($defaultPriorityMethod))->isStatic()) {
throw new InvalidArgumentException(
sprintf(
'Default priority method "%s::%s()" of the "%s"-tagged collection on service "%s" must be static.',
$class,
$defaultPriorityMethod,
$tagName,
$serviceId
)
);
if (!($priorityReflMethod = $r->getMethod($defaultPriorityMethod))->isStatic()) {
throw new InvalidArgumentException(sprintf('Default priority method "%s::%s()" of the "%s"-tagged collection on service "%s" must be static.', $class, $defaultPriorityMethod, $tagName, $serviceId));
}

if (!$rpm->isPublic()) {
throw new InvalidArgumentException(
sprintf(
'Method "%s::%s()" should be public: tag "%s" on service "%s" is missing default priority method.',
$class,
$defaultPriorityMethod,
$tagName,
$serviceId
)
);
if (!$priorityReflMethod->isPublic()) {
throw new InvalidArgumentException(sprintf('Method "%s::%s()" should be public: tag "%s" on service "%s" is missing default priority method.', $class, $defaultPriorityMethod, $tagName, $serviceId));
}

$priority = $rpm->invoke(null);
$priority = $priorityReflMethod->invoke(null);

if (!\is_int($priority)) {
throw new InvalidArgumentException(
sprintf(
'Method "%s::%s()" should return an integer, got %s: tag "%s" on service "%s" is missing default priority method.',
$class,
$defaultPriorityMethod,
\gettype($priority),
$tagName,
$serviceId
)
);
throw new InvalidArgumentException(sprintf('Method "%s::%s()" should return an integer, got %s: tag "%s" on service "%s" is missing default priority method.', $class, $defaultPriorityMethod, \gettype($priority), $tagName, $serviceId));
}
}

Expand Down
20 changes: 0 additions & 20 deletions src/Symfony/Component/DependencyInjection/Loader/Configurator/ContainerConfigurator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,6 @@ function tagged(string $tag, string $indexAttribute = null, string $defaultIndex

/**
* Creates a lazy iterator by tag name.
*
* @param string $tag
* @param string|null $indexAttribute
* @param string|null $defaultIndexMethod
* @param bool $needsIndexes
* @param string|null $defaultPriorityMethod
*
* @return TaggedIteratorArgument
*/
function tagged_iterator(string $tag, string $indexAttribute = null, string $defaultIndexMethod = null, bool $needsIndexes = false, string $defaultPriorityMethod = null): TaggedIteratorArgument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$needsIndexes should be removed, it's always false for iterators

{
Expand All @@ -143,14 +135,6 @@ function tagged_iterator(string $tag, string $indexAttribute = null, string $def

/**
* Creates a service locator by tag name.
*
* @param string $tag
* @param string $indexAttribute
* @param string|null $defaultIndexMethod
* @param bool $needsIndexes
* @param string|null $defaultPriorityMethod
*
* @return ServiceLocatorArgument
*/
function tagged_locator(string $tag, string $indexAttribute, string $defaultIndexMethod = null, bool $needsIndexes = true, string $defaultPriorityMethod = null): ServiceLocatorArgument
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$needsIndexes should be removed, it's always true for locators

{
Expand All @@ -159,10 +143,6 @@ function tagged_locator(string $tag, string $indexAttribute, string $defaultInde

/**
* Creates an expression.
*
* @param string $expression
*
* @return Expression
*/
function expr(string $expression): Expression
{
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy