Dynamic bundle assets

symfony · fabpot · Jul 9, 2019 · Jun 20, 2019 · Jul 9, 2019 · c16fcc93e2068dc1cebe63c757674902651dfc9d
commit c16fcc93e2068dc1cebe63c757674902651dfc9d
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php
@@ -137,7 +137,13 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $validAssetDirs = [];
         /** @var BundleInterface $bundle */
         foreach ($kernel->getBundles() as $bundle) {
-            if (!is_dir($originDir = $bundle->getPath().'/Resources/public')) {
+            if (!method_exists($bundle, 'getPublicPath')) {
+                @trigger_error('Not defining "getPublicPath()" method is deprecated since Symfony 4.4 and will not be supported in 5.0.', E_USER_DEPRECATED);
+                $publicPath = 'Resources/public';
+            } else {
+                $publicPath = $bundle->getPublicPath();
+            }
+            if (!is_dir($originDir = $bundle->getPath().\DIRECTORY_SEPARATOR.$publicPath)) {
                 continue;
             }
 

diff --git a/src/Symfony/Component/HttpKernel/Bundle/Bundle.php b/src/Symfony/Component/HttpKernel/Bundle/Bundle.php
@@ -135,6 +135,11 @@ public function registerCommands(Application $application)
     {
     }
 
+    public function getPublicPath(): string
+    {
+        return 'Resources/public';
 return $this->getProjectDir().'/var/log'; 
 return $this->getProjectDir().'/var/log'; 
+    }
+
     /**
      * Returns the bundle's container extension class.
      *

diff --git a/src/Symfony/Component/HttpKernel/Bundle/BundleInterface.php b/src/Symfony/Component/HttpKernel/Bundle/BundleInterface.php
@@ -19,6 +19,8 @@
  * BundleInterface.
  *
  * @author Fabien Potencier <fabien@symfony.com>
+ *
+ * @method string getPublicPath() Returns relative path for public assets
  */
 interface BundleInterface extends ContainerAwareInterface
 {

diff --git a/src/Symfony/Component/HttpKernel/Tests/KernelTest.php b/src/Symfony/Component/HttpKernel/Tests/KernelTest.php
@@ -627,7 +627,7 @@ protected function getBundle($dir = null, $parent = null, $className = null, $bu
     {
         $bundle = $this
             ->getMockBuilder('Symfony\Component\HttpKernel\Bundle\BundleInterface')
-            ->setMethods(['getPath', 'getParent', 'getName'])
+            ->setMethods(['getPath', 'getPublicPath', 'getParent', 'getName'])
             ->disableOriginalConstructor()
         ;
 
@@ -649,6 +649,12 @@ protected function getBundle($dir = null, $parent = null, $className = null, $bu
             ->willReturn($dir)
         ;
 
+        $bundle
+            ->expects($this->any())
+            ->method('getPublicPath')
+            ->willReturn('Resources/public')
+        ;
+
         $bundle
             ->expects($this->any())
             ->method('getParent')