symfony · fabpot · Jun 29, 2019 · Jun 28, 2019 · derrabus · Jun 29, 2019
diff --git a/src/Symfony/Bridge/Doctrine/Validator/DoctrineInitializer.php b/src/Symfony/Bridge/Doctrine/Validator/DoctrineInitializer.php
@@ -28,7 +28,7 @@ public function __construct(ManagerRegistry $registry)
         $this->registry = $registry;
     }
 
-    public function initialize($object)
+    public function initialize(object $object)
     {
         $manager = $this->registry->getManagerForClass(\get_class($object));
         if (null !== $manager) {

diff --git a/src/Symfony/Component/Validator/ConstraintViolationList.php b/src/Symfony/Component/Validator/ConstraintViolationList.php
@@ -72,7 +72,7 @@ public function addAll(ConstraintViolationListInterface $otherList)
     /**
      * {@inheritdoc}
      */
-    public function get($offset)
+    public function get(int $offset)
     {
         if (!isset($this->violations[$offset])) {
             throw new \OutOfBoundsException(sprintf('The offset "%s" does not exist.', $offset));
@@ -84,23 +84,23 @@ public function get($offset)
     /**
      * {@inheritdoc}
      */
-    public function has($offset)
+    public function has(int $offset)
     {
         return isset($this->violations[$offset]);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function set($offset, ConstraintViolationInterface $violation)
+    public function set(int $offset, ConstraintViolationInterface $violation)
     {
         $this->violations[$offset] = $violation;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function remove($offset)
+    public function remove(int $offset)
     {
         unset($this->violations[$offset]);
     }

diff --git a/src/Symfony/Component/Validator/ConstraintViolationListInterface.php b/src/Symfony/Component/Validator/ConstraintViolationListInterface.php
@@ -37,7 +37,7 @@ public function addAll(self $otherList);
      *
      * @throws \OutOfBoundsException if the offset does not exist
      */
-    public function get($offset);
+    public function get(int $offset);
 
     /**
      * Returns whether the given offset exists.
@@ -46,20 +46,20 @@ public function get($offset);
      *
      * @return bool Whether the offset exists
      */
-    public function has($offset);
+    public function has(int $offset);
 
     /**
      * Sets a violation at a given offset.
      *
      * @param int                          $offset    The violation offset
      * @param ConstraintViolationInterface $violation The violation
      */
-    public function set($offset, ConstraintViolationInterface $violation);
+    public function set(int $offset, ConstraintViolationInterface $violation);
 
     /**
      * Removes a violation at a given offset.
      *
      * @param int $offset The offset to remove
      */
-    public function remove($offset);
+    public function remove(int $offset);
 }
diff --git a/src/Symfony/Component/Validator/Context/ExecutionContext.php b/src/Symfony/Component/Validator/Context/ExecutionContext.php
@@ -143,7 +143,7 @@ public function __construct(ValidatorInterface $validator, $root, TranslatorInte
     /**
      * {@inheritdoc}
      */
-    public function setNode($value, $object, MetadataInterface $metadata = null, $propertyPath)
+    public function setNode($value, ?object $object, MetadataInterface $metadata = null, string $propertyPath)
     {
         $this->value = $value;
         $this->object = $object;
@@ -154,7 +154,7 @@ public function setNode($value, $object, MetadataInterface $metadata = null, $pr
     /**
      * {@inheritdoc}
      */
-    public function setGroup($group)
+    public function setGroup(?string $group)
     {
         $this->group = $group;
     }
@@ -170,7 +170,7 @@ public function setConstraint(Constraint $constraint)
     /**
      * {@inheritdoc}
      */
-    public function addViolation($message, array $parameters = [])
+    public function addViolation(string $message, array $parameters = [])
     {
         $this->violations->add(new ConstraintViolation(
             $this->translator->trans($message, $parameters, $this->translationDomain),
@@ -188,7 +188,7 @@ public function addViolation($message, array $parameters = [])
     /**
      * {@inheritdoc}
      */
-    public function buildViolation($message, array $parameters = [])
+    public function buildViolation(string $message, array $parameters = [])
     {
         return new ConstraintViolationBuilder(
             $this->violations,
@@ -283,15 +283,15 @@ public function getPropertyName()
     /**
      * {@inheritdoc}
      */
-    public function getPropertyPath($subPath = '')
+    public function getPropertyPath(string $subPath = '')
     {
         return PropertyPath::append($this->propertyPath, $subPath);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function markGroupAsValidated($cacheKey, $groupHash)
+    public function markGroupAsValidated(string $cacheKey, string $groupHash)
     {
         if (!isset($this->validatedObjects[$cacheKey])) {
             $this->validatedObjects[$cacheKey] = [];
@@ -303,39 +303,39 @@ public function markGroupAsValidated($cacheKey, $groupHash)
     /**
      * {@inheritdoc}
      */
-    public function isGroupValidated($cacheKey, $groupHash)
+    public function isGroupValidated(string $cacheKey, string $groupHash)
     {
         return isset($this->validatedObjects[$cacheKey][$groupHash]);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function markConstraintAsValidated($cacheKey, $constraintHash)
+    public function markConstraintAsValidated(string $cacheKey, string $constraintHash)
     {
         $this->validatedConstraints[$cacheKey.':'.$constraintHash] = true;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function isConstraintValidated($cacheKey, $constraintHash)
+    public function isConstraintValidated(string $cacheKey, string $constraintHash)
     {
         return isset($this->validatedConstraints[$cacheKey.':'.$constraintHash]);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function markObjectAsInitialized($cacheKey)
+    public function markObjectAsInitialized(string $cacheKey)
     {
         $this->initializedObjects[$cacheKey] = true;
     }
 
     /**
      * {@inheritdoc}
      */
-    public function isObjectInitialized($cacheKey)
+    public function isObjectInitialized(string $cacheKey)
     {
         return isset($this->initializedObjects[$cacheKey]);
     }

diff --git a/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php b/src/Symfony/Component/Validator/Context/ExecutionContextInterface.php
@@ -67,7 +67,7 @@ interface ExecutionContextInterface
      * @param string $message The error message
      * @param array  $params  The parameters substituted in the error message
      */
-    public function addViolation($message, array $params = []);
+    public function addViolation(string $message, array $params = []);
 
     /**
      * Returns a builder for adding a violation with extended information.
@@ -86,7 +86,7 @@ public function addViolation($message, array $params = []);
      *
      * @return ConstraintViolationBuilderInterface The violation builder
      */
-    public function buildViolation($message, array $parameters = []);
+    public function buildViolation(string $message, array $parameters = []);
 
     /**
      * Returns the validator.
@@ -133,7 +133,7 @@ public function getObject();
      * @internal Used by the validator engine. Should not be called by user
      *           code.
      */
-    public function setNode($value, $object, MetadataInterface $metadata = null, $propertyPath);
+    public function setNode($value, ?object $object, MetadataInterface $metadata = null, string $propertyPath);
 
     /**
      * Sets the currently validated group.
@@ -143,7 +143,7 @@ public function setNode($value, $object, MetadataInterface $metadata = null, $pr
      * @internal Used by the validator engine. Should not be called by user
      *           code.
      */
-    public function setGroup($group);
+    public function setGroup(?string $group);
 
     /**
      * Sets the currently validated constraint.
@@ -165,7 +165,7 @@ public function setConstraint(Constraint $constraint);
      * @internal Used by the validator engine. Should not be called by user
      *           code.
      */
-    public function markGroupAsValidated($cacheKey, $groupHash);
+    public function markGroupAsValidated(string $cacheKey, string $groupHash);
 
     /**
      * Returns whether an object was validated in a specific validation group.
@@ -180,7 +180,7 @@ public function markGroupAsValidated($cacheKey, $groupHash);
      * @internal Used by the validator engine. Should not be called by user
      *           code.
      */
-    public function isGroupValidated($cacheKey, $groupHash);
+    public function isGroupValidated(string $cacheKey, string $groupHash);
 
     /**
      * Marks a constraint as validated for an object.
@@ -191,7 +191,7 @@ public function isGroupValidated($cacheKey, $groupHash);
      * @internal Used by the validator engine. Should not be called by user
      *           code.
      */
-    public function markConstraintAsValidated($cacheKey, $constraintHash);
+    public function markConstraintAsValidated(string $cacheKey, string $constraintHash);
 
     /**
      * Returns whether a constraint was validated for an object.
@@ -204,7 +204,7 @@ public function markConstraintAsValidated($cacheKey, $constraintHash);
      * @internal Used by the validator engine. Should not be called by user
      *           code.
      */
-    public function isConstraintValidated($cacheKey, $constraintHash);
+    public function isConstraintValidated(string $cacheKey, string $constraintHash);
 
     /**
      * Marks that an object was initialized.
@@ -216,7 +216,7 @@ public function isConstraintValidated($cacheKey, $constraintHash);
      *
      * @see ObjectInitializerInterface
      */
-    public function markObjectAsInitialized($cacheKey);
+    public function markObjectAsInitialized(string $cacheKey);
 
     /**
      * Returns whether an object was initialized.
@@ -230,7 +230,7 @@ public function markObjectAsInitialized($cacheKey);
      *
      * @see ObjectInitializerInterface
      */
-    public function isObjectInitialized($cacheKey);
+    public function isObjectInitialized(string $cacheKey);
 
     /**
      * Returns the violations generated by the validator so far.
@@ -340,5 +340,5 @@ public function getPropertyName();
      *                string if the validator is currently validating the
      *                root value of the validation graph.
      */
-    public function getPropertyPath($subPath = '');
+    public function getPropertyPath(string $subPath = '');
 }
diff --git a/src/Symfony/Component/Validator/Mapping/Cache/CacheInterface.php b/src/Symfony/Component/Validator/Mapping/Cache/CacheInterface.php
@@ -25,7 +25,7 @@ interface CacheInterface
      *
      * @param string $class
      */
-    public function has($class);
+    public function has(string $class);
 
     /**
      * Returns the metadata for the given class from the cache.
@@ -34,7 +34,7 @@ public function has($class);
      *
      * @return ClassMetadata|false A ClassMetadata instance or false on miss
      */
-    public function read($class);
+    public function read(string $class);
 
     /**
      * Stores a class metadata in the cache.

diff --git a/src/Symfony/Component/Validator/Mapping/Cache/DoctrineCache.php b/src/Symfony/Component/Validator/Mapping/Cache/DoctrineCache.php
@@ -36,15 +36,15 @@ public function setCache(Cache $cache)
     /**
      * {@inheritdoc}
      */
-    public function has($class): bool
+    public function has(string $class): bool
     {
         return $this->cache->contains($class);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function read($class)
+    public function read(string $class)
     {
         return $this->cache->fetch($class);
     }

diff --git a/src/Symfony/Component/Validator/Mapping/Cache/Psr6Cache.php b/src/Symfony/Component/Validator/Mapping/Cache/Psr6Cache.php
@@ -31,15 +31,15 @@ public function __construct(CacheItemPoolInterface $cacheItemPool)
     /**
      * {@inheritdoc}
      */
-    public function has($class)
+    public function has(string $class)
     {
         return $this->cacheItemPool->hasItem($this->escapeClassName($class));
     }
 
     /**
      * {@inheritdoc}
      */
-    public function read($class)
+    public function read(string $class)
     {
         $item = $this->cacheItemPool->getItem($this->escapeClassName($class));
 

diff --git a/src/Symfony/Component/Validator/Mapping/ClassMetadata.php b/src/Symfony/Component/Validator/Mapping/ClassMetadata.php
@@ -364,15 +364,15 @@ public function mergeConstraints(self $source)
     /**
      * {@inheritdoc}
      */
-    public function hasPropertyMetadata($property)
+    public function hasPropertyMetadata(string $property)
     {
         return \array_key_exists($property, $this->members);
     }
 
     /**
      * {@inheritdoc}
      */
-    public function getPropertyMetadata($property)
+    public function getPropertyMetadata(string $property)
     {
         if (!isset($this->members[$property])) {
             return [];

diff --git a/src/Symfony/Component/Validator/Mapping/ClassMetadataInterface.php b/src/Symfony/Component/Validator/Mapping/ClassMetadataInterface.php
@@ -81,7 +81,7 @@ public function isGroupSequenceProvider();
      *
      * @return bool
      */
-    public function hasPropertyMetadata($property);
+    public function hasPropertyMetadata(string $property);
 
     /**
      * Returns all metadata instances for the given named property.
@@ -94,7 +94,7 @@ public function hasPropertyMetadata($property);
      * @return PropertyMetadataInterface[] A list of metadata instances. Empty if
      *                                     no metadata exists for the property.
      */
-    public function getPropertyMetadata($property);
+    public function getPropertyMetadata(string $property);
 
     /**
      * Returns the name of the backing PHP class.

diff --git a/src/Symfony/Component/Validator/Mapping/GenericMetadata.php b/src/Symfony/Component/Validator/Mapping/GenericMetadata.php
@@ -185,7 +185,7 @@ public function hasConstraints()
      *
      * Aware of the global group (* group).
      */
-    public function findConstraints($group)
+    public function findConstraints(string $group)
     {
         return isset($this->constraintsByGroup[$group])
             ? $this->constraintsByGroup[$group]

diff --git a/src/Symfony/Component/Validator/Mapping/MetadataInterface.php b/src/Symfony/Component/Validator/Mapping/MetadataInterface.php
@@ -62,5 +62,5 @@ public function getConstraints();
      *
      * @return Constraint[] A list of constraint instances
      */
-    public function findConstraints($group);
+    public function findConstraints(string $group);
 }
diff --git a/src/Symfony/Component/Validator/ObjectInitializerInterface.php b/src/Symfony/Component/Validator/ObjectInitializerInterface.php
@@ -27,5 +27,5 @@ interface ObjectInitializerInterface
      *
      * @param object $object The object to validate
      */
-    public function initialize($object);
+    public function initialize(object $object);
 }
diff --git a/src/Symfony/Component/Validator/Tests/Fixtures/FakeClassMetadata.php b/src/Symfony/Component/Validator/Tests/Fixtures/FakeClassMetadata.php
@@ -15,7 +15,7 @@
 
 class FakeClassMetadata extends ClassMetadata
 {
-    public function addCustomPropertyMetadata($propertyName, $metadata)
+    public function addCustomPropertyMetadata(string $propertyName, $metadata)
     {
         if (!isset($this->members[$propertyName])) {
             $this->members[$propertyName] = [];