Skip to content

[WebProfilerBundle] Removed templateExists method #32461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

yceruto
Copy link
Member

@yceruto yceruto commented Jul 9, 2019

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR not needed

Follow up #32458, since Twig 2.0 the exists() method is part of the LoaderInterface.

I'm not removing the Symfony\Bundle\TwigBundle\Controller\ExceptionController::templateExists() method because the whole class will be removed after #31398

See also #32462

@yceruto yceruto force-pushed the remove_template_exists branch from 61b2d96 to 059113e Compare July 9, 2019 15:54
fabpot added a commit that referenced this pull request Jul 9, 2019
…(yceruto)

This PR was merged into the 4.4 branch.

Discussion
----------

[WebProfilerBundle] Deprecating templateExists method

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | not needed

Follow up #32458, so in 5.0 we can remove these methods safely.

I'm not deprecating the `Symfony\Bundle\TwigBundle\Controller\ExceptionController::templateExists()` method because the whole class is being deprecated in #31398

See also #32461

Commits
-------

2e81e45 Deprecating templateExists method
@fabpot
Copy link
Member

fabpot commented Jul 9, 2019

Thank you @yceruto.

@fabpot fabpot merged commit 059113e into symfony:master Jul 9, 2019
fabpot added a commit that referenced this pull request Jul 9, 2019
This PR was merged into the 5.0-dev branch.

Discussion
----------

[WebProfilerBundle] Removed templateExists method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | not needed

Follow up #32458, since Twig 2.0 the `exists()` method is part of the `LoaderInterface`.

I'm not removing the `Symfony\Bundle\TwigBundle\Controller\ExceptionController::templateExists()` method because the whole class will be removed after #31398

See also #32462

Commits
-------

059113e Removed templateExists method
@yceruto yceruto deleted the remove_template_exists branch July 9, 2019 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy