[HttpKernel] Do not extend the new SF 4.3 ControllerEvent so we can make it final #33282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Aug 21, 2019
|
Thank you @Tobion. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 21, 2019
…so we can make it final (Tobion) This PR was merged into the 4.3 branch. Discussion ---------- [HttpKernel] Do not extend the new SF 4.3 ControllerEvent so we can make it final | Q | A | ------------- | --- | Branch? | 4.3 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | BC breaks? | unlikely | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | | License | MIT | Doc PR | See #33152 (comment) Remember the ControllerEvent is new in SF 4.3 so we just go back to what it was before 4.3 Commits ------- 00140b6 Do not extend the new SF 4.3 ControllerEvent so we can make it final
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #33152 (comment)
Remember the ControllerEvent is new in SF 4.3 so we just go back to what it was before 4.3