[4.4] Fix some leftovers #33752
Merged
[4.4] Fix some leftovers #33752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Sep 29, 2019
| @@ -96,7 +96,7 @@ | |||
| <argument type="collection"> | |||
| <argument type="service" key="cli"> | |||
| <service class="Symfony\Component\VarDumper\Command\Descriptor\CliDescriptor"> | |||
| <argument type="service" id="var_dumper.cli_dumper" /> | |||
| <argument type="service" id="var_dumper.contextualized_cli_dumper.inner" /> | |||
There was a problem hiding this comment.
/cc @ktherage FYI
There was a problem hiding this comment.
@nicolas-grekas Sorry, i've missed this one.
| @@ -126,6 +126,10 @@ public function configure(Event $event = null) | |||
| $output = $output->getErrorOutput(); | |||
| } | |||
| $this->exceptionHandler = function ($e) use ($app, $output) { | |||
| if (!$e instanceof \Exception) { | |||
| $e = new FatalThrowableError($e); | |||
chalasr
approved these changes
Sep 29, 2019
d39759c to
b416c12
Compare
fancyweb
approved these changes
Sep 30, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Sep 30, 2019
This PR was merged into the 4.4 branch. Discussion ---------- [4.4] Fix some leftovers | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | #33756 | License | MIT | Doc PR | - Found while running console commands with the Symfony Demo. Commits ------- b416c12 [4.4] Fix some leftovers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while running console commands with the Symfony Demo.