[DI] dont mandate a class on inline services with a factory #33782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should this be covered by a test to prevent regressions ? I think the answer should be yes. |
xabbuh
reviewed
Oct 1, 2019
src/Symfony/Component/DependencyInjection/Compiler/CheckDefinitionValidityPass.php
Outdated
Show resolved
Hide resolved
124ea65 to
a2665d1
Compare
|
Now with tests. |
javiereguiluz
approved these changes
Oct 2, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Oct 2, 2019
…ory (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] dont mandate a class on inline services with a factory | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This check is too strict, useless and boring for inline services :) Commits ------- a2665d1 [DI] dont mandate a class on inline services with a factory
nicolas-grekas
added a commit
that referenced
this pull request
Oct 30, 2019
…nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [DI] fix regexp for anonymous services with no class set | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follows #33782 Commits ------- a302d20 [DI] fix regexp for anonymous services with no class set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check is too strict, useless and boring for inline services :)