Add support for NO_COLOR env var

symfony · nicolas-grekas · Nov 8, 2019 · Nov 6, 2019 · Nov 8, 2019 · c1b0a8e956e86bf86913c481b7a169ebd04a77b1
commit c1b0a8e956e86bf86913c481b7a169ebd04a77b1
diff --git a/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php b/src/Symfony/Bridge/PhpUnit/DeprecationErrorHandler.php
@@ -357,6 +357,11 @@ private static function hasColorSupport()
             return false;
         }
 
+        // Follow https://no-color.org/
+        if (isset($_SERVER['NO_COLOR']) || false !== getenv('NO_COLOR')) {
+            return false;
+        }
+
         if ('Hyper' === getenv('TERM_PROGRAM')) {
             return true;
         }

@@ -13,6 +13,7 @@ CHANGELOG
  * deprecated returning `null` from `Command::execute()`, return `0` instead
  * Deprecated the `Application::renderException()` and `Application::doRenderException()` methods,
    use `renderThrowable()` and `doRenderThrowable()` instead.
+ * added support for the `NO_COLOR` env var (https://no-color.org/)
 
 4.3.0
 -----

@@ -97,6 +97,11 @@ protected function doWrite($message, $newline)
      */
     protected function hasColorSupport()
     {
+        // Follow https://no-color.org/
+        if (isset($_SERVER['NO_COLOR']) || false !== getenv('NO_COLOR')) {
+            return false;
+        }
+
         if ('Hyper' === getenv('TERM_PROGRAM')) {
             return true;
         }

diff --git a/src/Symfony/Component/VarDumper/CHANGELOG.md b/src/Symfony/Component/VarDumper/CHANGELOG.md
@@ -10,6 +10,7 @@ CHANGELOG
  * added the stamps of a message after it is dispatched in `TraceableMessageBus` and `MessengerDataCollector` collected data
  * added `UuidCaster`
  * made all casters final
+ * added support for the `NO_COLOR` env var (https://no-color.org/)
 
 4.3.0
 -----

diff --git a/src/Symfony/Component/VarDumper/Dumper/CliDumper.php b/src/Symfony/Component/VarDumper/Dumper/CliDumper.php
@@ -582,6 +582,11 @@ private function hasColorSupport($stream): bool
             return false;
         }
 
+        // Follow https://no-color.org/
+        if (isset($_SERVER['NO_COLOR']) || false !== getenv('NO_COLOR')) {
+            return false;
+        }
+
         if ('Hyper' === getenv('TERM_PROGRAM')) {
             return true;
         }