[FrameworkBundle] allow using secrets when the sodium ext is missing #34275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Nov 7, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Nov 7, 2019
…is missing (nicolas-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] allow using secrets when the sodium ext is missing | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - When all secrets are defined as env vars, there is no need for the sodium vault, yet it chokes on instantiation currently. Commits ------- 326284a [FrameworkBundle] allow using secrets when the sodium ext is missing
stof
reviewed
Nov 7, 2019
| if (!\function_exists('sodium_crypto_box_seal')) { | ||
| $this->lastMessage = sprintf('Secret "%s" cannot be revealed as the "sodium" PHP extension missing. Try running "composer require paragonie/sodium_compat" if you cannot enable the extension."', $name); | ||
|
|
||
| return null; |
There was a problem hiding this comment.
should we return null silently here, or throw an exception when trying to use reveal without the sodium extension ? seal is throwing.
There was a problem hiding this comment.
we should return null, that's the design here - it allows e.g. the env var process to take over and provide a fallback behavior
stof
reviewed
Nov 7, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Nov 8, 2019
…as-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] fix SodiumVault after stof review | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As spotted by @stof in #34275 (review) Commits ------- a594599 [FrameworkBundle] fix SodiumVault after stof review
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Nov 8, 2019
…as-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [FrameworkBundle] fix SodiumVault after stof review | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As spotted by @stof in symfony/symfony#34275 (review) Commits ------- a594599078 [FrameworkBundle] fix SodiumVault after stof review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When all secrets are defined as env vars, there is no need for the sodium vault, yet it chokes on instantiation currently.