Skip to content

[Console] Remove restriction for choices to be strings #34790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2020
Merged

[Console] Remove restriction for choices to be strings #34790

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3349d3c
Remove restriction for choices to be strings
LordZardeck Dec 3, 2019
a022308
[Console] Add tests for removing restriction for choices to be strings
YaFou Aug 23, 2020
d276cc9
[Console] Cast associative choices questions keys to string
ogizanagi Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Remove restriction for choices to be strings
  • Loading branch information
@LordZardeck
LordZardeck authored Dec 3, 2019
commit 3349d3ce8974a0935fa94f545933f2cedc53b4d2
2 changes: 1 addition & 1 deletion src/Symfony/Component/Console/Question/ChoiceQuestion.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ private function getDefaultValidator(): callable
throw new InvalidArgumentException(sprintf($errorMessage, $value));
}

$multiselectChoices[] = (string) $result;
$multiselectChoices[] = $result;
}

if ($multiselect) {
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy