[Form] Stop automatic left '0' str_padding on the 'days' field on a date choice widget. #3490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice widget. Can't see of any other way of disabling this otherwise? (Doesn't respect format=>'MMMM-d-y' like date single_text widget, although it probably should...)
|
ping @bschussek |
|
It's |
| @@ -83,7 +83,7 @@ public function buildForm(FormBuilder $builder, array $options) | |||
| $months[$month] = str_pad($month, 2, '0', STR_PAD_LEFT); | |||
| } | |||
| foreach ($options['days'] as $day) { | |||
| $days[$day] = str_pad($day, 2, '0', STR_PAD_LEFT); | |||
| $days[$day] = str_pad($day, 0, '0', STR_PAD_LEFT); | |||
|
@bschussek ping |
|
I have worked on a PR that should fix this issue, along with other DateType improvements. I'll submit it as soon as the master branch tests pass again. |
|
What does this PR fix? Why do you consider the current behaviour buggy? Can you please add a testcase? |
|
Closing this PR in favor of #3490 |
fabpot
added a commit
that referenced
this pull request
Jul 10, 2012
Commits ------- 5b057f8 [Form] Fixed DateType to use "format" for creating the year and day choices Discussion ---------- [Form] Fixed DateType to use "format" for creating the year and day choices Bug fix: yes Feature addition: no Backwards compatibility break: no Symfony2 tests pass: yes Fixes the following tickets: #3490 Todo: -
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't see of any other way of disabling this otherwise?
(Doesn't respect format=>'MMMM-d-y' like date 'single_text' widget, although it probably should...?)