Skip to content

[HttpFoundation] use utf8mb4_bin to align code with documentation #35020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2019
Merged

[HttpFoundation] use utf8mb4_bin to align code with documentation #35020

merged 1 commit into from
Dec 18, 2019

Conversation

bendavies
Copy link
Contributor

@bendavies bendavies commented Dec 18, 2019

Q A
Branch? 3.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This aligns the code with the documentation, which says to use utf8mb4 for the character set when using mysql.

@bendavies bendavies changed the base branch from master to 3.4 December 18, 2019 10:28
@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Dec 18, 2019
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not a bugfix because nobody uses collations on session table)

@nicolas-grekas
Copy link
Member

Thank you @bendavies.

nicolas-grekas added a commit that referenced this pull request Dec 18, 2019
…mentation (bendavies)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpFoundation] use utf8mb4_bin to align code with documentation

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

This aligns the code with [the documentation](https://symfony.com/doc/3.4/doctrine/pdo_session_storage.html#mysql), which says to use `utf8mb4` for the character set when using mysql.

Commits
-------

3739ec9 use utf8mb4_bin to align code with documentation
@nicolas-grekas nicolas-grekas merged commit 3739ec9 into symfony:3.4 Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy