[HttpClient] fix casting responses to PHP streams #35195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e86dcfa to
81b50b5
Compare
81b50b5 to
35c08ef
Compare
|
I think it will also help to solve this: #35187 (comment) |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 4, 2020
…-grekas) This PR was merged into the 4.4 branch. Discussion ---------- [HttpClient] fix casting responses to PHP streams | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This patch is required to properly deal with casting responses to PHP streams. This changes a public method, but we can't expect anyone to override it as it's totally internal. Found when working on (and required by) #35115 Commits ------- 35c08ef [HttpClient] fix casting responses to PHP streams
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is required to properly deal with casting responses to PHP streams.
This changes a public method, but we can't expect anyone to override it as it's totally internal.
Found when working on (and required by) #35115