Skip to content

[AssetBundle] Move xml service configuration to php #37255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2020
Merged

[AssetBundle] Move xml service configuration to php #37255

merged 1 commit into from
Jun 17, 2020

Conversation

NguyenTruongLinh
Copy link
Contributor

@NguyenTruongLinh NguyenTruongLinh commented Jun 12, 2020 •
edited by Tobion
Loading

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets Part of #37186
License MIT
Doc PR

@xabbuh xabbuh added this to the next milestone Jun 12, 2020
xabbuh
xabbuh requested changes Jun 12, 2020
View reviewed changes
Copy link
Member

@xabbuh xabbuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this @NguyenTruongLinh. I have left some minor comments for a few things that need to be changed.

@NguyenTruongLinh
Copy link
Contributor Author

Thank you for working on this @NguyenTruongLinh. I have left some minor comments for a few things that need to be changed.

Thank you, I have updated it.

Tobion
Tobion suggested changes Jun 15, 2020
View reviewed changes
@Tobion
Copy link
Contributor

Tobion commented Jun 15, 2020

Commas are missing: https://fabbot.io/report/symfony/symfony/37255/ede897ca97ec592202fccb223b8ea59170a8dd98

Tobion
Tobion suggested changes Jun 16, 2020
View reviewed changes
Copy link
Contributor

@Tobion Tobion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabbot coding style checks are still failing

@NguyenTruongLinh
Copy link
Contributor Author

fabbot coding style checks are still failing

I have updated, but AppVeyor build test failed. What am I missing?

@Tobion
Copy link
Contributor

Tobion commented Jun 17, 2020

Test failure is unrelated

@Tobion
Copy link
Contributor

Tobion commented Jun 17, 2020

Thank you @NguyenTruongLinh.

@Tobion Tobion merged commit 6a6f478 into symfony:master Jun 17, 2020
@nicolas-grekas nicolas-grekas modified the milestones: next, 5.2 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xabbuh xabbuh xabbuh requested changes

@Tobion Tobion Tobion approved these changes

Assignees
No one assigned
Labels
FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.
5 participants
@NguyenTruongLinh @Tobion @xabbuh @nicolas-grekas @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy