[Notifier] Make Freemobile config more flexible

symfony · fabpot · Aug 6, 2020 · Aug 6, 2020 · Aug 6, 2020 · 4dfde6ae7cff453e12412dfb10732ab05f3555e3
commit 4dfde6ae7cff453e12412dfb10732ab05f3555e3
diff --git a/src/Symfony/Component/Notifier/Bridge/FreeMobile/FreeMobileTransport.php b/src/Symfony/Component/Notifier/Bridge/FreeMobile/FreeMobileTransport.php
@@ -37,7 +37,7 @@ public function __construct(string $login, string $password, string $phone, Http
     {
         $this->login = $login;
         $this->password = $password;
-        $this->phone = $phone;
+        $this->phone = str_replace('+33', '0', $phone);
 
         parent::__construct($client, $dispatcher);
     }
@@ -49,7 +49,7 @@ public function __toString(): string
 
     public function supports(MessageInterface $message): bool
     {
-        return $message instanceof SmsMessage && $this->phone === $message->getPhone();
+        return $message instanceof SmsMessage && $this->phone === str_replace('+33', '0', $message->getPhone());
     }
 
     protected function doSend(MessageInterface $message): SentMessage

diff --git a/src/Symfony/Component/Notifier/Bridge/FreeMobile/Tests/FreeMobileTransportTest.php b/src/Symfony/Component/Notifier/Bridge/FreeMobile/Tests/FreeMobileTransportTest.php
@@ -22,33 +22,37 @@ final class FreeMobileTransportTest extends TestCase
 {
     public function testToStringContainsProperties(): void
     {
-        $transport = $this->initTransport();
+        $transport = $this->getTransport('0611223344');
 
         $this->assertSame('freemobile://host.test?phone=0611223344', (string) $transport);
     }
 
     public function testSupportsMessageInterface(): void
     {
-        $transport = $this->initTransport();
+        $transport = $this->getTransport('0611223344');
 
         $this->assertTrue($transport->supports(new SmsMessage('0611223344', 'Hello!')));
+        $this->assertTrue($transport->supports(new SmsMessage('+33611223344', 'Hello!')));
         $this->assertFalse($transport->supports(new SmsMessage('0699887766', 'Hello!')));
         $this->assertFalse($transport->supports($this->createMock(MessageInterface::class), 'Hello!'));
+
+        $transport = $this->getTransport('+33611223344');
+
+        $this->assertTrue($transport->supports(new SmsMessage('0611223344', 'Hello!')));
+        $this->assertTrue($transport->supports(new SmsMessage('+33611223344', 'Hello!')));
     }
 
     public function testSendNonSmsMessageThrowsException(): void
     {
-        $transport = $this->initTransport();
+        $transport = $this->getTransport('0611223344');
 
         $this->expectException(LogicException::class);
 
         $transport->send(new SmsMessage('0699887766', 'Hello!'));
     }
 
-    private function initTransport(): FreeMobileTransport
+    private function getTransport(string $phone): FreeMobileTransport
     {
-        return (new FreeMobileTransport(
-            'login', 'pass', '0611223344', $this->createMock(HttpClientInterface::class)
-        ))->setHost('host.test');
+        return (new FreeMobileTransport('login', 'pass', $phone, $this->createMock(HttpClientInterface::class)))->setHost('host.test');
     }
 }