Skip to content

[HttpClient][HttpClientTrait] don't calculate alternatives if option is auth_ntlm #38173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2020
Merged

[HttpClient][HttpClientTrait] don't calculate alternatives if option is auth_ntlm #38173

merged 1 commit into from
Sep 15, 2020

Conversation

ybenhssaien
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets no
License MIT
Doc PR symfony/symfony-docs#...

If option is auth_ntlm an exception is thrown, $alternatives then is not used.

OskarStark
OskarStark reviewed Sep 13, 2020
View reviewed changes
@nicolas-grekas nicolas-grekas added this to the 4.4 milestone Sep 14, 2020
@ybenhssaien ybenhssaien force-pushed the httpclient-codefix branch 4 times, most recently from 1a17811 to 960b907 Compare September 14, 2020 16:18
@nicolas-grekas
Copy link
Member

Thank you @ybenhssaien.

@nicolas-grekas nicolas-grekas merged commit 61c1175 into symfony:4.4 Sep 15, 2020
This was referenced Sep 27, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
HttpClient Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ybenhssaien @nicolas-grekas @OskarStark @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy