Skip to content

[Notifier] fix factory definition of notifier transports #38175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jschaedl
Copy link
Contributor

@jschaedl jschaedl commented Sep 13, 2020

Q A
Branch? master
Bug fix? yes
New feature? no
Deprecations? no
Tickets #37298
License MIT
Doc PR -

With a fresh install of Symfony symfony new --version=next and after adding the Notifier component composer req symfony/notifier I got the following errors:

In PhpDumper.php line 1843:
                                                                                       
  Cannot dump definition because of invalid class name ('chatter.transport_factory').  

and

In PhpDumper.php line 1843:
                                                                                       
  Cannot dump definition because of invalid class name ('texter.transport_factory').  

This PR fixes this bug.

@fabpot
Copy link
Member

fabpot commented Sep 13, 2020

Thank you @jschaedl.

@fabpot fabpot merged commit 0f5ac5d into symfony:master Sep 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy