Skip to content

[PropertyInfo] Extract from default value doesn't set collection boolean #38446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2020
Merged

[PropertyInfo] Extract from default value doesn't set collection boolean #38446

merged 1 commit into from
Oct 7, 2020

Conversation

Korbeil
Copy link
Contributor

@Korbeil Korbeil commented Oct 6, 2020

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #38445
License MIT
Doc PR N/A

This PR will fix the issue by checking if the type is an array or not and setting the collection boolean based on this check.

@Korbeil Korbeil requested a review from dunglas as a code owner October 6, 2020 18:02
@Korbeil Korbeil force-pushed the fix/no-collection-extract-default-value branch from de624d5 to f6ab0a7 Compare October 6, 2020 18:03
@Korbeil Korbeil force-pushed the fix/no-collection-extract-default-value branch 2 times, most recently from 671d0f7 to cac6fe2 Compare October 6, 2020 19:55
@Korbeil Korbeil force-pushed the fix/no-collection-extract-default-value branch from cac6fe2 to 33d37e5 Compare October 6, 2020 20:24
@fabpot
Copy link
Member

fabpot commented Oct 7, 2020

Thank you @Korbeil.

@fabpot fabpot merged commit 392f2e0 into symfony:5.1 Oct 7, 2020
@Korbeil Korbeil mentioned this pull request Oct 7, 2020
Merged
@fabpot fabpot mentioned this pull request Oct 14, 2020
Merged
@fabpot fabpot mentioned this pull request Oct 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@lyrixx lyrixx lyrixx approved these changes

Assignees
No one assigned
Labels
Bug PropertyInfo Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Korbeil @fabpot @dunglas @lyrixx @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy