Add test SKIP_UNINITIALIZED_PROPERTIES

symfony · idsulik · Nov 3, 2020 · Nov 3, 2020 · Nov 3, 2020 · Nov 3, 2020
commit c4d4a83b52be5afa37deb9d18eadeb2bc82b7795
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ObjectDummy2.php b/src/Symfony/Component/Serializer/Tests/Normalizer/Features/ObjectDummy2.php
@@ -0,0 +1,16 @@
+<?php
+
+namespace Symfony\Component\Serializer\Tests\Normalizer\Features;
+
+use Symfony\Component\PropertyAccess\Exception\UninitializedPropertyException;
+
+class ObjectDummy2
+{
+    public $bar;
+
+    //simulate typed property access
+    public function getFakeUninitializedProperty()
+    {
+        throw new UninitializedPropertyException();
+    }
+}
diff --git a/...y/Component/Serializer/Tests/Normalizer/Features/SkipUninitializedPropertiesTestTrait.php b/...y/Component/Serializer/Tests/Normalizer/Features/SkipUninitializedPropertiesTestTrait.php
@@ -0,0 +1,32 @@
+<?php
+
+namespace Symfony\Component\Serializer\Tests\Normalizer\Features;
+
+use Symfony\Component\PropertyAccess\Exception\UninitializedPropertyException;
+use Symfony\Component\Serializer\Normalizer\NormalizerInterface;
+
+/**
+ * Test AbstractObjectNormalizer::SKIP_UNINITIALIZED_PROPERTIES.
+ */
+trait SkipUninitializedPropertiesTestTrait
+{
+    abstract protected function getNormalizerForSkipUninitializedProperties(): NormalizerInterface;
+
+    public function testSkipUninitializedProperties()
+    {
+        $dummy = new ObjectDummy2();
+        $dummy->bar = 'present';
+
+        $normalizer = $this->getNormalizerForSkipUninitializedProperties();
+        $result = $normalizer->normalize($dummy, null, ['skip_uninitialized_properties' => true]);
+        $this->assertSame(['bar' => 'present'], $result);
+    }
+
+    public function testWithoutSkipUninitializedProperties()
+    {
+        $this->expectException(UninitializedPropertyException::class);
+
+        $normalizer = $this->getNormalizerForSkipUninitializedProperties();
+        $normalizer->normalize(new ObjectDummy2(), null);
+    }
+}
diff --git a/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php b/src/Symfony/Component/Serializer/Tests/Normalizer/ObjectNormalizerTest.php
@@ -43,6 +43,7 @@
 use Symfony\Component\Serializer\Tests\Normalizer\Features\ObjectDummy;
 use Symfony\Component\Serializer\Tests\Normalizer\Features\ObjectToPopulateTestTrait;
 use Symfony\Component\Serializer\Tests\Normalizer\Features\SkipNullValuesTestTrait;
+use Symfony\Component\Serializer\Tests\Normalizer\Features\SkipUninitializedPropertiesTestTrait;
 use Symfony\Component\Serializer\Tests\Normalizer\Features\TypeEnforcementTestTrait;
 
 /**
@@ -59,6 +60,7 @@ class ObjectNormalizerTest extends TestCase
     use MaxDepthTestTrait;
     use ObjectToPopulateTestTrait;
     use SkipNullValuesTestTrait;
+    use SkipUninitializedPropertiesTestTrait;
     use TypeEnforcementTestTrait;
 
     /**
@@ -506,6 +508,13 @@ protected function getNormalizerForSkipNullValues(): ObjectNormalizer
         return new ObjectNormalizer();
     }
 
+    // skip uninitialized
+
+    protected function getNormalizerForSkipUninitializedProperties(): ObjectNormalizer
+    {
+        return new ObjectNormalizer();
+    }
+
     // type enforcement
 
     protected function getDenormalizerForTypeEnforcement(): ObjectNormalizer