Skip to content

[Security] voters now are going to be obligated to return int values #39248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

[Security] voters now are going to be obligated to return int values #39248

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0b3c3f6
voters now are going to be obligated to return int values
adeptofvoltron Nov 30, 2020
f4e2ab6
code style
adeptofvoltron Nov 30, 2020
d714896
type check
adeptofvoltron Nov 30, 2020
27e3166
moving deprecation to 5.3
adeptofvoltron Nov 30, 2020
da6567a
moving deprecation to 5.3
adeptofvoltron Nov 30, 2020
f3c63c8
move deprecation to AccessDecisionManager
adeptofvoltron Nov 30, 2020
a70aeff
Merge branch '5.x' of github.com:symfony/symfony into 5.x
adeptofvoltron Nov 30, 2020
34ace90
triggering deprecation
adeptofvoltron Nov 30, 2020
464d7ad
Merge branch '5.x' of github.com:symfony/symfony into 5.x
adeptofvoltron Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
type check
  • Loading branch information
@adeptofvoltron
adeptofvoltron committed Nov 30, 2020
commit d71489626a5df59c47ce4e52a5fb2651dcd10968
2 changes: 1 addition & 1 deletion src/Symfony/Component/Security/Core/Authorization/Voter/TraceableVoter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function vote(TokenInterface $token, $subject, array $attributes): int
{
$result = $this->voter->vote($token, $subject, $attributes);

if (false === \in_array($result, [self::ACCESS_DENIED, self::ACCESS_GRANTED, self::ACCESS_ABSTAIN])) {
if (false === \in_array($result, [self::ACCESS_DENIED, self::ACCESS_GRANTED, self::ACCESS_ABSTAIN], true)) {
@trigger_error(
sprintf('Return value of "%s::vote()" should always be of the type int since Symfony 5.0, %s returned.', \get_class($this->voter), \gettype($result)),
\E_USER_DEPRECATED
Expand Down
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy