Skip to content

improve exception message if symfony/security-csrf is missing #40314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2021
Merged

improve exception message if symfony/security-csrf is missing #40314

merged 1 commit into from
Feb 26, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 26, 2021

Q A
Branch? 4.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #37452
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Feb 26, 2021
@xabbuh xabbuh requested a review from yceruto as a code owner February 26, 2021 10:27
@xabbuh xabbuh mentioned this pull request Feb 26, 2021
Closed
@wouterj
Copy link
Member

wouterj commented Feb 26, 2021

In the issue, @javiereguiluz says "The real solution is that you must set the framework.csrf_protection config option to true or null". This PR changed it to "install symfony/security-csrf". Can we confirm that installing will always fix it, or do we need to add the config option to the message?

@xabbuh
Copy link
Member Author

xabbuh commented Feb 26, 2021

The option is enabled by default as soon as the symfony/security-csrf package is enabled. So I am not sure if it's worth adding the option too.

@javiereguiluz
Copy link
Member

I agree with Christian ... installing the missing package is probably enough to solve this issue (I can't test it myself now). Thanks!

wouterj
wouterj approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty, 👍

@Nyholm
Copy link
Member

Nyholm commented Feb 26, 2021

Thank you for the PR and the reviews

@Nyholm Nyholm merged commit b3c4d63 into symfony:4.4 Feb 26, 2021
@xabbuh xabbuh deleted the issue-37452 branch February 26, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@Nyholm Nyholm Nyholm approved these changes

@derrabus derrabus derrabus approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @wouterj @javiereguiluz @Nyholm @derrabus @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy