Skip to content

[Notifier] Mercure bridge: bump mercure dependency to 0.5 #40671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 6, 2021
Merged

[Notifier] Mercure bridge: bump mercure dependency to 0.5 #40671

merged 2 commits into from
Apr 6, 2021

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Apr 1, 2021 •
edited
Loading

Q A
Branch? 5.x
Bug fix? no
New feature? yes
Deprecations? no
License MIT
Doc PR symfony/symfony-docs#15179

Bump Mercure bridge's symfony/mercure dependency to 0.5 to deal with hubs instead of publishers.

To be able to use HandlerRegistry::all method, this PR needs symfony/mercure#50 to be merged and released.

@mtarld mtarld requested a review from OskarStark as a code owner April 1, 2021 14:38
@mtarld
Copy link
Contributor Author

mtarld commented Apr 1, 2021

fabbot.io is trigerring a false positive

@mtarld mtarld mentioned this pull request Apr 1, 2021
Merged
azjezz
azjezz approved these changes Apr 1, 2021
View reviewed changes
@mtarld mtarld force-pushed the mercure-05 branch 2 times, most recently from c5504da to b843d60 Compare April 1, 2021 14:58
azjezz
azjezz reviewed Apr 1, 2021
View reviewed changes
azjezz
azjezz approved these changes Apr 2, 2021
View reviewed changes
Copy link
Contributor

@azjezz azjezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

not sure why mercure-bundle is not available when running psalm, the way it's configured here is a bit weird.

chalasr
chalasr requested changes Apr 3, 2021
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root composer.json needs to require mercure-bundle 0.3

@OskarStark OskarStark requested review from chalasr and dunglas April 4, 2021 05:54
@dunglas
Copy link
Member

dunglas commented Apr 4, 2021

The test failure looks related.

chalasr
chalasr reviewed Apr 5, 2021
View reviewed changes
@mtarld
Copy link
Contributor Author

mtarld commented Apr 6, 2021

About the failing tests, it's because of a BC break between 0.5.0 and 0.5.1. In fact, MockHub signature has changed.
Maybe we can require at least ^0.5.1? (Or even ^0.5.2 to have the all method available)

@OskarStark
Copy link
Contributor

Maybe we can require at least ^0.5.1? (Or even ^0.5.2 to have the all method available)

Lets require ^0.5.2 then 👍

OskarStark
OskarStark approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thank you

@OskarStark OskarStark requested a review from chalasr April 6, 2021 10:13
@chalasr
Copy link
Member

chalasr commented Apr 6, 2021

Thank you @mtarld and @azjezz!

@chalasr chalasr merged commit de14349 into symfony:5.x Apr 6, 2021
@mtarld mtarld deleted the mercure-05 branch April 6, 2021 10:26
@chalasr chalasr removed request for dunglas and chalasr April 6, 2021 10:27
@chalasr chalasr added this to the 5.x milestone Apr 6, 2021
OskarStark added a commit to symfony/symfony-docs that referenced this pull request Apr 7, 2021
@OskarStark
feature #15179 [Notifier] Mercure bridge: bump mercure dependency to …
8bf4aea 
…0.5 (mtarld)

This PR was merged into the 5.3-dev branch.

Discussion
----------

[Notifier] Mercure bridge: bump mercure dependency to 0.5

Documentation for symfony/symfony#40671

Commits
-------

af96b34 Update doc for mercure 0.5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr requested changes

@dunglas dunglas dunglas approved these changes

@OskarStark OskarStark OskarStark approved these changes

@azjezz azjezz azjezz approved these changes

Assignees
No one assigned
Labels
Feature Notifier Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@mtarld @dunglas @OskarStark @chalasr @azjezz @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy