* LightSmsTransport.php - suggestion for pull request #40712 #40733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jderusse
reviewed
Apr 7, 2021
|
@jderusse You as always right 👍 Checked. Now works without any errors :) |
|
@StaffNowa Can you please squash your commits? https://stackoverflow.com/a/5189600/4363634 |
|
omg something made bad... 💀 |
|
Finally |
|
Well done :) |
|
Good catch, thanks @StaffNowa. |
jderusse
reviewed
Apr 7, 2021
Comment on lines
+127
to
+128
| if (0 !== (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) { | ||
| $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1; |
There was a problem hiding this comment.
this is duplicated.
- if (0 !== (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1) {
- $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;
+ $errorCode = (int) ($content['error'] ?? $content['']['error'] ?? $content[$phone]['error']) ?? -1;
+ if (0 !== $code) {There was a problem hiding this comment.
In line two see mistake in word $code, but found and fixed 👍
Nyholm
added a commit
that referenced
this pull request
Apr 8, 2021
…StaffNowa) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [Notifier] LightSMS duplicated $errorCode variable fix | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #40712, #40733 | License | MIT | Doc PR | - Removed duplicated variable $errorCode. Many thanks for: @OskarStark, @jderusse and special thanks for @chalasr for fast rebase course at night :))) Commits ------- 867769e [Notifier] LightSMS duplicated $errorCode variable fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After remove issets still get warnings about undefined variables. My solution for this: