[Notifier] Add warning if transport factory was not added for new bridge #41416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1b9e9d0 to
f3aca43
Compare
OskarStark
approved these changes
May 26, 2021
|
@nicolas-grekas are you fine with the warning? |
3 tasks
|
A new bridge is almost always merged before that the subtree split repository is created. |
Sounds good 👍 |
|
I confirm that the subtree splits are created after merging the related PR. |
|
@jschaedl What's the status of this PR? |
|
I think I've just fixed the same issue as this PR in #41969 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #40845 we added a test to make sure the framework integration for a new notifier bridge is configured correctly. But in #41375 we realised that a failing test will prevent us from merging a new bridge were we don't have a subtree split repository yet.
A possible solution could be to just show a warning instead of letting the test fail which I would like to propose here.