Skip to content

[PhpUnitBridge] fix symlink to bridge in docker by making its path relative #43799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2021
Merged

[PhpUnitBridge] fix symlink to bridge in docker by making its path relative #43799

merged 1 commit into from
Oct 28, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40879
License MIT
Doc PR -

This is a simpler and less generic version of #40879 that should fit the goal:

When running symfony from a docker container with a volume mapped to the host, it may cause issues when symlinks are generated from container root, as absolute links.

For composer to generate a relative symlink, declaration of the path repository should be relative.

@carsonbot carsonbot added this to the 4.4 milestone Oct 28, 2021
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 28, 2021
Closed
@nicolas-grekas nicolas-grekas merged commit 2a98147 into symfony:4.4 Oct 28, 2021
This was referenced Oct 29, 2021
Merged
Merged
@nicolas-grekas nicolas-grekas deleted the pub-rel branch October 29, 2021 16:15
@weaverryan weaverryan mentioned this pull request Nov 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @chalasr @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy