Does this work fine for commands accepting array arguments, where the number of accepted arguments is infinite ?

based on your comment in #47432 (comment), shouldn't this PR target 5.4 ?

Does this work fine for commands accepting array arguments, where the number of accepted arguments is infinite ?

Yes, the $acceptedIndex += \count($argumentValue); line should take care of that (the number of argument values equals the number of tokens passed to the infinite array argument).

Existing tests should cover all these array argument cases:

based on your comment in #47432 (comment), shouldn't this PR target 5.4 ?

🤦‍♂️ yep

Note that my PR also targets 5.4, but anyway thanks for the fix here!

@wouterj but if we are after the last written argument value, we still want completion for a next one in case of an infinite list. That's what I'm unsure about.

Marking this as WIP, the failing test in FrameworkBundle reveals some errors with this approach (we should only compare argument tokens, not all tokens as this includes options and option values).

@wouterj but if we are after the last written argument value, we still want completion for a next one in case of an infinite list. That's what I'm unsure about.

That should be covered by: yield [CompletionInput::fromTokens(['bin/console', 'symfony', 'sensiolabs'], 3), null];

This data set replicates bin/console symfony sensiolabs | and the test case verifies that we're still completing the array argument (the null here indicates that there is no completion value, because there is no value for the last item in the array).

Closing here for now. I haven't looked into this for years, and haven't seen any other community reports about this for the past 2.5 years. It's a complex issue to fix, and for now not worth it imho.