[HttpClient] Add support for "friendsofphp/well-known-implementations" #47950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stof
approved these changes
Oct 21, 2022
kbond
approved these changes
Oct 22, 2022
fabpot
approved these changes
Oct 22, 2022
|
Thank you @nicolas-grekas. |
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Feb 10, 2023
…mplementations" (nicolas-grekas) This PR was merged into the 6.2 branch. Discussion ---------- [HttpClient] Revert support for "friendsofphp/well-known-implementations" | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - This reverts PR #47950 The major features of "friendsofphp/well-known-implementations" are now available in "php-http/discovery" [v1.15.0](https://github.com/php-http/discovery/releases/tag/1.15.0), see: - php-http/discovery#209 - php-http/discovery#208 Given the extremely low download stats of "friendsofphp/well-known-implementations", I propose to just remove support for it as a bugfix: https://packagist.org/packages/friendsofphp/well-known-implementations This will save us from maintaining this integration, which is unused code in practice anyway. Commits ------- 081aa00 Revert "[HttpClient] Add support for "friendsofphp/well-known-implementations""
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/FriendsOfPHP/well-known-implementations for what this is about.
This provides an alternative auto-discovery mechanism to php-http/discovery.