Skip to content

[DependencyInjection] Allow enum as service parameter in php config files #48045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2022
Merged

[DependencyInjection] Allow enum as service parameter in php config files #48045

merged 1 commit into from
Nov 1, 2022

Conversation

alexndlm
Copy link
Contributor

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR

@carsonbot carsonbot added this to the 6.2 milestone Oct 29, 2022
nicolas-grekas
nicolas-grekas approved these changes Oct 30, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Would make sense for 6.2 to me, this looks like an oversight.

@fabpot
Copy link
Member

fabpot commented Nov 1, 2022

Thank you @alexndlm.

@fabpot fabpot mentioned this pull request Nov 1, 2022
Closed
@fabpot fabpot merged commit 1f83ce7 into symfony:6.2 Nov 1, 2022
@fabpot fabpot mentioned this pull request Nov 19, 2022
Merged
@stof stof mentioned this pull request Feb 28, 2023
Closed
This was referenced May 16, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@derrabus derrabus derrabus approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
6 participants
@alexndlm @fabpot @nicolas-grekas @derrabus @maxbeckers @carsonbot
pFad - Phonifier reborn

Pfad - The Proxy pFad of © 2024 Garber Painting. All rights reserved.

Note: This service is not intended for secure transactions such as banking, social media, email, or purchasing. Use at your own risk. We assume no liability whatsoever for broken pages.


Alternative Proxies:

Alternative Proxy

pFad Proxy

pFad v3 Proxy

pFad v4 Proxy