prevent the installation of unstable phpdocumentor/type-resolver releases #48471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm mixed on this. We do want to spot regressions before they are tagged. I'm fine merging but only if we revert very soon. |
|
@nicolas-grekas I didn't spot your comment before merging. I will closely monitor the phpdocumentor/type-resolver repository to revert this change as soon as possible. |
|
@xabbuh https://github.com/phpDocumentor/TypeResolver/releases/tag/1.7.0 has been relased |
xabbuh
added a commit
that referenced
this pull request
Mar 19, 2023
…abbuh) This PR was merged into the 5.4 branch. Discussion ---------- [Serializer] re-allow phpdocumentor/type-resolver 1.7 | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | reverts #48471 | License | MIT | Doc PR | Commits ------- 0776dec re-allow phpdocumentor/type-resolver 1.7
|
reverted in #49727 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest to not make use of the development version of the upcoming minor release of phpdocumentor/type-resolver as it is quite unstable at the moment and causes our pipeline to fail constantly.