[Notifier] [Line] Fix tests #48477
Merged
[Notifier] [Line] Fix tests #48477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
commented
Dec 5, 2022
Comment on lines
-51
to
-59
| public function testSendChatMessageWithMoreThan2000CharsThrowsLogicException() | ||
| { | ||
| $transport = $this->createTransport(); | ||
|
|
||
| $this->expectException(LengthException::class); | ||
| $this->expectExceptionMessage('The subject length of a Line message must not exceed 1000 characters.'); | ||
|
|
||
| $transport->send(new ChatMessage(str_repeat('囍', 1001))); | ||
| } |
There was a problem hiding this comment.
This Test is obsolete, as we removed the check for the max subject length in the initial PR. Anyway, creating a ChatMessage with 1001 chars would never raise the limit of 2000 🤷
Lets remove this test
16ee9fb to
9a87852
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows
cc @kurozumi