[Uid] Fix validating nil and max uuid #48831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fancyweb
commented
Dec 30, 2022
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | #48800 |
| License | MIT |
| Doc PR | - |
7b4230c to
bb57880
Compare
fancyweb
commented
Dec 30, 2022
| return true; | ||
| } | ||
|
|
||
| if (__CLASS__ === static::class && 'ffffffff-ffff-ffff-ffff-ffffffffffff' === strtr($uuid, 'F', 'f')) { |
There was a problem hiding this comment.
if (self::MAX === strtr($uuid, 'F', 'f') && (\in_array(static::class, [__CLASS__, MaxUuid::class], true))) { on 6.2
fancyweb
commented
Dec 30, 2022
chalasr
approved these changes
Dec 30, 2022
derrabus
reviewed
Dec 30, 2022
derrabus
approved these changes
Dec 30, 2022
fabpot
approved these changes
Dec 30, 2022
|
Thank you @fancyweb. |
This was referenced Jan 24, 2023
Merged
Merged
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.